[PATCH v2 7/8] dts: meson-gxbb: Switch to using upstream DT

Sumit Garg sumit.garg at linaro.org
Fri Dec 22 15:00:52 CET 2023


On Fri, 22 Dec 2023 at 19:24, Tom Rini <trini at konsulko.com> wrote:
>
> On Fri, Dec 22, 2023 at 06:50:32PM +0530, Sumit Garg wrote:
> > On Fri, 22 Dec 2023 at 18:01, Tom Rini <trini at konsulko.com> wrote:
> > >
> > > On Fri, Dec 22, 2023 at 11:42:07AM +0530, Sumit Garg wrote:
> > >
> > > > Although there were still some variations in board DTS files based on
> > > > meson-gxbb SoC but I think those were minor differences from upstream
> > > > and shouldn't impact boot on these devices.
> > > >
> > > > So switch to upstream DT via mirroring amlogic/ directory from
> > > > devicetree-rebasing/src/arm64/amlogic/ directory. And thereby directly
> > > > building DTB from there including *-u-boot.dtsi files from
> > > > arch/$(ARCH)/dts/ directory.
> > > >
> > > > Reviewed-by: Neil Armstrong <neil.armstrong at linaro.org>
> > > > Signed-off-by: Sumit Garg <sumit.garg at linaro.org>
> > > > ---
> > > >  configs/nanopi-k2_defconfig           | 3 ++-
> > > >  configs/odroid-c2_defconfig           | 3 ++-
> > > >  configs/p200_defconfig                | 3 ++-
> > > >  configs/p201_defconfig                | 3 ++-
> > > >  configs/videostrong-kii-pro_defconfig | 3 ++-
> > > >  configs/wetek-hub_defconfig           | 3 ++-
> > > >  configs/wetek-play2_defconfig         | 3 ++-
> > > >  dts/arch/arm64/Makefile               | 9 +++++++++
> > > >  dts/arch/arm64/amlogic                | 1 +
> > > >  9 files changed, 24 insertions(+), 7 deletions(-)
> > > >  create mode 120000 dts/arch/arm64/amlogic
> > >
> > > Do we need all of the Makefile portions of this? One of the things that
> > > works today is that trees listed in ONFIG_DEFAULT_DEVICE_TREE (and a few
> > > other variables) will be automatically built. We might just need the new
> > > Makefiles to just have:
> > > include $(srctree)/scripts/Makefile.dts
> > > and then the trees a given config will need will be built.
> >
> > That sounds fine for Amlogic SoC and many others too with
> > CONFIG_DEFAULT_DEVICE_TREE="" CONFIG_OF_LIST="" options available.
> > However, if in future we have truely generalized U-Boot (like efforts
> > for Qcom platform) then CONFIG_OF_LIST="" may become an overloaded
> > choice.
>
> I don't object to listing them when needed, I'm just not totally sure on
> how the use case really works out. But we can cross that when we get
> there, too.

Agree and I have similar concerns about it.

-Sumit

>
> --
> Tom


More information about the U-Boot-Custodians mailing list