[PATCH v2 3/8] scripts/Makefile.lib: Statically define *-u-boot.dtsi files location

Simon Glass sjg at chromium.org
Wed Dec 27 08:55:32 CET 2023


Hi Sumit,

On Tue, Dec 26, 2023 at 10:09 AM Sumit Garg <sumit.garg at linaro.org> wrote:
>
> On Tue, 26 Dec 2023 at 15:17, Simon Glass <sjg at chromium.org> wrote:
> >
> > Hi Sumit,
> >
> > On Fri, Dec 22, 2023 at 6:12 AM Sumit Garg <sumit.garg at linaro.org> wrote:
> > >
> > > Allow u-boot to build DTB from a different directory tree such that
> > > *-u-boot.dtsi files can be included from a common location. Currently
> > > that location is arch/$(ARCH)/dts/, so statically define that common
> > > location.
> > >
> > > This is needed for platform owners to start building DTB files from
> > > devicetree-rebasing directory but still being able to include
> > > *-u-boot.dtsi files.
> > >
> >
> > This is a v2 patch but I don't see a change log?
>
> I usually prefer to keep change logs in the cover letter [1].
>
> [1] https://lore.kernel.org/all/20231222061208.3009970-1-sumit.garg@linaro.org/
>

As a reviewer I much prefer to see the changes with the patch. If you
use patman you can have both, I suppose.

> >
> > > Signed-off-by: Sumit Garg <sumit.garg at linaro.org>
> > > ---
> > >  scripts/Makefile.lib | 25 ++++++++++++++-----------
> > >  1 file changed, 14 insertions(+), 11 deletions(-)
> >
> > Reviewed-by: Simon Glass <sjg at chromium.org>
> >

Regards,
Simon


More information about the U-Boot-Custodians mailing list