[U-Boot-Users] Re: [PATCH] 2/4: bootz command

[Holger Schurig]

> > +    ulong addr = 0x40000;
> Please do not use any magic hardwired constants.
> Can we use existent logic again, i. e. load_addr ?

You can blame me for this. I did not run over load_addr so far.


> Did this really compile for any PowerPC or MIPS board?

No idea. I will not go and install various cross-compilers for board I don't 
have and where I don't even have the URL for the cross-compiler to download 
from. For now, it's an arm-only patch as long as no one from the 
PPC/MIPS/Whatever community needs it.

After all, there is already arm-only code in u-boot, e.g. the code from 
arm_lib/* that I used.

> On  PowerPC,  there  is  neither  a  header  file   "tag.h"   nor   a
> cleanup_before_linux() function...

The tag.h is a file that I made. Wasn't it part of my original patch?