[U-Boot-Users] [PATCH] 1/5: cmd_boot

[Robert Schwebel]

On Mon, Mar 31, 2003 at 12:12:09PM +0200, Wolfgang Denk wrote:
> Which "whitespace" problem are you trying to fix? To me  the  current
> output looks good:
> 
> 	=> bdi
> 	memstart    = 0x00000000
> 	memsize     = 0x01000000
> 	flashstart  = 0x40000000
> 	flashsize   = 0x00800000
> 	flashoffset = 0x00040000
> 	sramstart   = 0x00000000
> 	sramsize    = 0x00000000
> 	immr_base   = 0xFFF00000
> 	bootflags   = 0x00000001
> 	intfreq     =     50 MHz
> 	busfreq     =     50 MHz
> 	ethaddr     = 00:D0:93:00:7B:8B
> 	IP addr     = 10.0.0.99
> 	baudrate    = 115200 bps

... but you have tried it on ppc, not on ARM :-) Your = is in column 13,
and so it is in my patch. 

> > +	/*
> > +	 * Gather any trailing characters (for instance, the ^D which
> > +	 * is sent by 'cu' after sending a file), and give the
> > +	 * box some time (100 * 1 ms)
> > +	 */
> > +	for (i=0; i<100; ++i) {
> > +		if (serial_tstc()) {
> > +			(void) serial_getc();
> > +		}
> > +		udelay(1000);
> > +	}
> 
> This makes no sense to  me.  load_serial_bin()  is  used  for  kermit
> serial  protocol download, but "cu" is used for S-Record (ASCII file)
> download. So how would "cu" disturb load_serial_bin() ?

Oops, documentation-cut-and-paste error. It's the same with kermit.
Without the code (which was there before including the comment, I just
moved it to the proper position, which I forgot in the last patch you've
already applied). 

Robert 
-- 
 Dipl.-Ing. Robert Schwebel | http://www.pengutronix.de
 Pengutronix - Linux Solutions for Science and Industry
   Braunschweiger Str. 79,  31134 Hildesheim, Germany
   Handelsregister:  Amtsgericht Hildesheim, HRA 2686
    Phone: +49-5121-28619-0 |  Fax: +49-5121-28619-4