[U-Boot-Users] watchdog reset in mpc824x timer interrupt.

Gleb Natapov gleb at nbase.co.il
Fri Sep 19 11:03:06 CEST 2003


Hello Wolfgang,

On Thu, Sep 18, 2003 at 10:22:26AM +0200, Wolfgang Denk wrote:
> in message <20030916120707.GA3629 at nbase.co.il> you wrote:
> > 
> >  The attached patch moves most of the things related to timer interrupt to
> > ppc_lib/interrupts.c leaving only cpu specific code in cpu/$(CPU)/interrupts.c
> > 
> > I only checked it on MPC8245. It works for me.
> > 
> > Can you look at the patch please.
> > 
> > CHANGELOG:
> > Move most of the things related to timer interrupt to ppc_lib/interrupts.c
> 
> You do much more than just this. I appreciate most of  your  cleanup,
> but I have a few requests:
> 
> * Please don't  create  a  new  (and  undocumented!!)  config  option
>   CONFIG_ACTIVITY_MONITOR  -  we  already  have  CONFIG_SHOW_ACTIVITY
>   which serves exactly this purpose. I see no need for a new option.
Yes CONFIG_SHOW_ACTIVITY is exactly what I need. I didn't find it first time. Thanks.

> 
> * Instead of just collecting common stuff in a common file you change
>   interfaces here and there. Can you please describe  these  changes,
>   and the reasons for them.
I don't quite understand what interfaces I changed. But I can explain how I see it working
now.

There are common interrupt_init() and timer_interrupt() for all PPC archs.
interrupt_init() calls interrupt_init_cpu() for cpu specific initialization.
interrupt_init_cpu() should set decrementer_count to appropriate value. If
cpu resets decrementer automatically after interrupt (ppc4xx) it should set
decrementer_count to zero.
timer_interrupt() calls timer_interrupt_cpu() for cpu specific handling.
If board has wahtchdog/status_led/other_activity_monitor it works automatically
from general timer_interrupt().

> 
> * Please keep existing Copyright notices in place.
I hope new patch contains proper Copyright notices in place.


begin 644 interrupts.patch.gz
M'XL("$O":C\``VEN=&5R<G5P=',N<&%T8V@`[5U[=]K(DO];_A0UF7OG@@$C
M\;*-)]D03!QV_;J`;V9V9HZ.+&2L#2`B"3_N3/:S;U5WZX'0"P?/(QN?Q!BI
MN[JZJ[KZ5]75TMB\N8'*TCZ'R@\PMN;NF"XL*]>6Y5:O+<T>5W5K8LS=ZE0?
M[^GBSMXBYMY.I5))KBG59+E>D5N5V@'(<KNNM)O[>[+W`R6Y+LL[I5(IK05!
MX["B'(*BM!O-=J.Q1N/U:ZC4:H?E.I3H0]F'UZ]W@'[,&RB42K;E:JYEJ^9\
M;#S`JY=0<,Q_&]8-X`W]5K,=J$+DRD_R+\7B#DBK55^"?+0#GW9*.Z5OS9NQ
M<0/=B_.W_1-U^.[BO=KICOK_ZH]^W"G=6>886&=4Y]:Z5S7=->],]Q$*RZDU
MGX!KS at S'U6:+XD[IUS5:H\[H:JB>]HYW2A)UH.`7A[]#H?OV1'WWW\AQK0 at O
MD2$D(4DX5NJMH=GNM:&Y4"@>(5%CCH+=*3%N&4,KK!3,N0N:/>$<?/++C[.U
MX_9Q9HG?Z^JQ<G-=/U9N!PHB at UQK-TA'\BA(')%L#6DJ==(0^J at UF8:0?`UW
M:<^A(!>W)MAKS3%6Y4H2^_'LXE@]?H-2':+`[JRIYII3`\S93%NH+NSB'S;J
M5\&_4&3U^F=G at Z.5"M;BH-:2615K at 36^HYJ55^9,Q>^6[5)I5!;7U(%$[-R:
M-RY7W%*</G%U$JH$OY(R\4G#*[Z".E,P*4P'BU at +;-):J(NQYH[A)2LB%2*7
MOX/_E1_D&RZ)(OP&!06^_QX*M0:4.&-%TE3)USZH[JZ-%NQ6-U5B1B9&?D0J
MAWY;#SK]7]=M_\:Z7ONWA#K6*DH#E'J[5FO7#U?4L1:OTU$"V?JL-%OE%I3H
M0ZDQ?9:FQMBU)I.I42HQ=8:-35&:P5'D8LCD(+,J;XS3-+!Q;GE(6)`F+%0S
M\'1T.7?,R1RKDMD%HL%T+%5,^F)9W6\\/*C[#P]5I&K8]G+A.F&!)18)BRZQ
M$,D`):@P&=3;<J-=D].%F$HJESCKM7*K!B7\X,O7M^9<GR['!GRO6[/9PK;T
MO=M7T<O:?,RN[E2JNUO\J>Y4=BJ^9,:&;ALS at SJEZM9R[AY);''%6<:^PITV
M71IP8]F@&*TJZLK,U&W+,71K/G:`4]L^?T*!5%R;I^;<4-5`ETBS=RH3PU5G
MCET at 52SN5'[=J4 at K)0!O'A$E27-FX%G8PHO9#=Z`O\LOH`TO7MHOH(#?B]!&
MW:YX"P:O^BF>#VH0KXOFU]H4O$0:=8-&L5FOU6)R*S&]14DE]Q:E%-];K+72
M6RP8Z2VOROA([R\QL-9J0G^#9D5_J6 at Q:(=3->;:-9J88$J%.RB&&`J>J&F1
M.1L.U%[/)X1:RGOAP,U4FQ`DY"7 at 7G,`*<"U@:IK,#W%9G8J8]-):7/IB1$-
ME=_L49 at 9^H5+7\"'CS+$+7$'OB%;&O"Y[0E"]M;O`_;&=$4_2NMW5#1@$(AN
M=VW.<ZN-B`;-P0V*?5PX[KVY.BG"=]_!-]XEL>AVSOHGG8OSWDE]V",0O;"Q
ML9O"B]4FVW`R at IEFSD'7EHZ!4IJT42$.'MKTZ^?YBS)?YF3$:V at 8&P?E`[[*
M`?\Y&0UZ)X->Y[C0&[WK#<Y[HYK:/Q_U!H.KRY%ZUAG^EXH%^D.\0FJ%;"Q1
MDFM,H-A<$R6ZUF/D@*H)7%R1U at H(!7"O]>D'U+RJP%*$:-;'+[$PVFZ!$]F`
M8D/I?.)RNM2F at ETLPMFL^&R*:<CG1+2Y(K,`T?82Q,.F'C493`2NW"])3-.'
M(I-119+\:;#&2,KDS,T&KO[&WGK#$-?J&J`'KD,-I=S`Q7:_5E9D[ASNPLA&
M6((C:<X64R8JM$S6'"HPMV!NX"1P+30-J);:=/J(PZXO;<TU]JAN=4?8/`)*
M=F`H"HYK+W47D'?49ESZZ'?(5I%Y7)]99"%\Q$7(C8\-1&;5^\ZH^^[XX at 3I
MI;N%`9B/(W/9[5]>=FM$13(>D(LYQVH+W5PL])IZ/R;FR2YR:\'7#&GM=F%%
MV)^\OT/8VV.86=9GLG%<#(PAE0DC;*J#`6*8DO.P#)9+7H$;=.ZUL6J>"@75
M*_RV1R)8[\(4T$26(OK`K6J\4D"40^:YX>C-+?>69AVJW]B"6X,O327!EM!J
MV/)09N+MV4)OIJ+MF`)1K!U3)!HC0G>IGAX"2">4(U!T4%;0;<*/0V$)JC2>
MJ[C:FA.LK at 07[S57OQU;DP@&YXQ$+B+0J1)>-QS'LK<-SS.A>3Y4+FT9E1,U
M$(H>J#^Y?FA2R=T++MZBTS)%?EW8%7_2XLQLT"ZZAT=,2HU6>;^.WM!A6>%B
M$J at SJ0G3_JC>&;KST_E`[0_^.?SEB$^2G0I:^E-+1SM_LYSSLB@;UW(?%X9#
M=ZN9V-I;:6!#3P)"KD0[<"3:PJ3F]23`7TCS>!(0<B7:[8W]")AX\&$S/P)"
MCD0[<",B?<WA1X"/7_+X$1!R)$1O5[P(H0`]YD2$<(P0/&MPS<.`-!<#XGT,
MULP at CY\AFB8(ONYH0(:GP0(LE6TX&PP"]1%@(00RG96Q$28QQG^`3`>"L9SD
M/6P:]J0`+9JSXX`:H*,PYFLB&392H:7#HD8TIND0'3;"Z!`!Z9P3+C!`1!@&
MQ31<DA^&=<PEDIO?[#DZ_CW3G`]BWR`,SF-18+:Z)>#;FMPB.UE2&LVRTN!>
MDF\1\=<O>VA8D8OSJ]-34:WBRR(2!Q18B1E/TA$8$:8)NHM@"'EST&F;TKC?
MWQIS@&O4#1DL`O-=BN3-)P9.`]N:<1+RWHH034=,.JQNNK>L]NA-#]O`CV%W
M(#`VGYX12)4$ITIQA3/PUQ,4LI*X5U-90=-<,U7L(F)$_8.8&6%/A:"Y[#O'
M:,AP%15CW?<[2]?"7BC?Z=HO-_91V"VES/<Q)%5%HX@&M/!B;BU8^4`=49=M
MQ]W3-5M=3!>V;L-O+^'R]'+0':BCW@^70]0O[^L9>LM<4:MDS1R7XB)AR779
M-&%S+5.58UR:I)%;&ZT@*GT4XU@$=45P,<-;(O,LD<=W:U!(VG:1-GB(#A:&
M;5IC4EZ:UBQ4[O#RJ*?:`M'"PQXH:,'U,KBW:&YLH^+:YF2"X^$3T5RT0IKC
M\HK&G6$_0A-QY\Q!90I\,W:[NH$#)TG<MT&4J?J-D7+:S-;G=;O$\D2K$)LB
MX?4OY#Q!IO<D2)T at H5&(T-+'#H+.YDZ5H#R,8]&)$G9C>&3^4\A)RNG29/LT
M>9R:6&=DOZ+LDU?3K+?EW%[-T[</]@_9]H&(<*3Y(U\W$7:_;B)\W43XNHF0
M/4&>L(F0Y at -\#:/_E</HRF&Y?@"EIEQ6%(X\^2!SY*M-PS#=LA;.-T6QB9++
MX_`@0!3QQS@<+B*YD&Z`A8#K9FK=.V5&@7D5H>$6DW&\Q^X^-?`?`))G"_Q_
M05%R^'\:)3^H-3(@Y5J)&$BY5B8`@@VHU=KR8;N1#U*F4,J*E.^SC!3\$+,]
M'Z1D]W13-:T8K.GEL62&UE^,<98:ME,U%B;6>/'[P].52'H&,/T:0?Y2(\C;
M#!)OAB%3PL-/3N!XYJ#RMJ=G<@2ZD at 0EF0BNEXYZ8QL?";\@:&OD0)69]7@(
MF-)/=J'O_L/AT2+;^H!P1',9(IE91!30GX8^(&JP\1LB"%PH_N$R9,',ZF&+
M7/12HUEN<0R%BM&[['?AGI6;&'.#\`;TST<XLZ9H8J'+:<&(@LF7M at G?@]+D
M86<RCWB;[N`-:VBX'+-M(=A<24VGP)7AH"52<N!NHOV'OV^0B?,VB>LR03]/
M-#(Q9`B__>;=`^_FN_=/2L"0)*^6.N at ->R,^UX*XG<1_$J)W,4RN)#2S[*M(
M at 8L?NAD,!GF\G$/V:R5Z'9_;&TX'24[_Q9N?PCT,Y4QL%FK<0DPQ,7BXX6Y!
M.:K*GP=,\\'(EIP%(R,E8F%DI,SF1RXR*.6`D0VV-T4?]<_/N`@'+%?R,(C!
M^*NJ:7_,2M%(V9T(:@7;%+R*<):W[F;`UH"IGR]A?_R,9`RET2 at W:<>I?N#)
M$%G`WM.FB6[AT-CF8H',6DN7[:/8^FUUL="K']"B&%/ZD\F!D+PNL;@O]7+[
MH[9%&.YMJ:FJMYRQ_;7?!XXG-2Y@^9'S.->/3/K]W`@]<1 at V0>I/Q>F)PY""
MU_^$:/WYDSFV.H]2<??34\>EXU[WM#/HJ2>G%V\ZI^IQ9]11+T<BS6/SC?@$
M]#^NO"(43QD<>8%_<A61]N&ER?S;$(''&VTY#0T#((<+6O,7B,!M+&M$<T*P
MJ.Y.]TS*"-%MCG+8VJAP9T!IM3QO(+:.\4"5*DJ0"?"L`+]6;Y7)WA]XAY&P
MX(R9<$IG47&AP-7D`\K&_ACR-5):*DDQ4[+(!YB0*JU/8OUQ?L(OO^R);Z3I
ME+5"QPBDPFYBN6(<#3IL)L;Y$'O21!!"*Y at LNK3]]>?+B7!OXI[E=*4*T9.=
MY*9L..\]KRG!7_IC7,6?<=SP)]S-[EE'/>T>J^]ZG<'H3:\S2BH8&8\XQRUZ
M0G>5G]C&HKG]D>/AGB,7&LPX,NLN:(P`-SJ9C,7CCR9'6(F>_XT*(;'3Z^?@
M<W4R,X-(9.&P_JVGX60I9>888DUVFAW&VG)R2_K*TI``"W`@'W,HN[)Z*+L2
M<RB[\O1#V5D""44P8KJ-NIXQV)^3"28E9H(]X_;97S9V\9?<0\O*RHH6B`M]
M).9D'5#D0VFUFZU\D8\GGS0A]%3"WZVM'#0Y6#MHPB_F"6^P##&90<W:H>!G
MBY+-#%G\@8=21!IS]_(L!-CO#!TA at G\DQ!$9Q^PQ(3*+=5`FM?(LX_1UK_#K
M7N'7Z$/<Y'BNR,.6@@O;/$DR_IR3)/Q8//-D2\W]T#9B%PN;DR7JQ8JY$W3U
MQ4R-CNUS;Q76E4:Y1JM.\["L-)_%GN8]R/)Y3C>D.MV??9[\ZUF7V+,N]?HA
M6XUK^QYJ^=:8.L9GGF_Q<RN_G%,NT3A+G'O\I),P4#`>=`/%<_K^[.*\^-P'
M8["/\]#XL48WV&[GVI%>7EZMP%5ABU&5U#@$;"<.$7L:*/TD4-9IH52?_1E6
M^C^74QUWFFC+[F\.UW>QT!NIKF],@:CK&U,DYB$+.5S?9$(Y3B,U&3BI-[?O
M:_*AW&2+_/<_5K2YT[G/4%*S[J]RSY1:D#]7]8\Y\>2YG]LY\`0QYK31D(M\
M8&%X.3 at 7IY7'=/@8;WD".5#*-05*K;JOP&QIH5K1IUT10<COVO^!QZL\;W=;
MIZL at I9F%Z<8UPY!HM!DL&]L,/W."#L0AE%`@"D\V_.1-#Q+&NBR$*)[DB_]!
MKO at VCGX]@X%]AN?'I2<!$%DTDI2!%#,M@`>MP_X9X="E:\U("YE791M32QOS
MQT$D^.7L`;:A7-XSS?[`W7#[(Y*CQQ88!KO%+8%RV.!;]$W9WZ*W/V*G4?FG
M4V_'N?"O7O?\ZDR]ZG>5\VX9EJ:N!!I09G+*K)A4+^2O<!@MGF?B';M:.5G&
M@\`4UK_LCXH>KLY0]9A'(;-EO%5CCQH at +UX\5^(Y%.U+WCC/V#>7_1-[&5YQ
M<"#P<Q\5I[!]/_X<7]^C:(0\BJB[\OL^S>W/XQ/\Q3?:P`-`GE9T+\[..N?'
M0UQ!N*=W3(_**FZ]:?Q)=W7$/E559^%*1SSP7_63>`,_)*MDV/G)*LL?ZBP?
M,.>ET6[NM^5FNA>4AV*^1W6W9/:H;OP0#W?F$];WN%%"0W78&_0[IZ0O]#C4
M+FL,9J at ZALW3`1S#-D7&+[+D6%.F1KZS$"6ZXL9+/ECB3TY"9"?>;4#(=ZJ/
MD:0]1_TGQ?0IQ3T$'SRMPB;.WJC=SB73*/^;^O:T,WQ79$[04]6`MCISR8$*
MYE0"*KI5'?`(YE.!&G]:>ZWU+"JP*C!&JW]^W/M!4GX_O<BM%>0:(Y9V;A'!
MF`XNPM9<G)_R.[J9YDSOV49ZLM1$@31-$46"-($6R$I;EMNUVF8:LDHHAV8H
M=:89^"$T8TDA4(G$=7K1.1ZJ;SI7QVKW7>?\I,<B&_Q`&4(0ZQZ7LN68'1?C
M?JPDD at RXH*3(VBU)"M7W0X?B*5R2%!(N:]<_M/1VT/NG>-[R2 at B5-2+XC(:K
M&8]#_F at VBEY[$$OBS*5*=FI>JW1R(#X$%G<W+-.X^Y)RN"]79`7_4=X'"E3.
M>)9_+)6\TI3+Y"L at 6F;.:@FUO83:7N at 6<38O'FUS<NOB^,ERA2P1N_?>FMY,
M4'9P;,P_E.&X=_X##*T;]UY#F-";3U`F..GGDS+<CU^/C?G#WA at 1)]:,IUQG
MET^FQC6<:ZZVL.[@^\F<__5Z9M_MZ=;LE5]]:."\)^#='?2.^Z,A,P)3G)2T
M"[`P+(3!"*LM,C:N;5XO78Z!$<XXK/["MO['T-V`GQ'>H:L36YN1?T;>%#BB
M.T?P:"T1K<\1Y*%6"(I at LC.35<MF%&86*L0C723]LIEE0$','&*)OIR<7\$)
M.R4YA<OE]=34X=34C3E:3$UP15>=6^3U^I%5>4M<^(/Z%EW!,4/V1V"89'.`
MCIH3TJ]A(XP$U1)4RX!C4M!<8A[]B055+"+'CX!.2U`W>0R"KK(P$Y&^M1:4
M3(Y$L9_W)FVW&&3S;Y;3,J.!I>%]?_3NXFH$G?,?X7UG,.B<CWX\8AX,';0Q
M[H2W0\Z*2>Z/9MO:W'WTNG#6&Y#1&'7>]$_I[2?8B[?]T7EO.(2W%P/HP"6N
M`?WN%3KD<'DUN+P8]O:`:012Y5J4/-*D)S,*>XP-5S.G3M#['U'$#G(X'<.M
M=D?.DFZ8=\B?AEJT>,R6(J.B,13.O#4W-)Q'%']!.(V3P391=9 at N1N3+Z@<R
M+J,WI>^5H7D((X/\.KB<:CI*=;@D"O6Z7(8WEN-B23YL';03"KW\HR[OP]6P
M0U?1/M+[?-93MTHI65>E^+2NE/<])9TU\]_FE/%^HI7]J>2WOA2/\KPJAS<V
M]UYAM+(FA+#`VG(1WIL+<RYXRPX>$7OACN1RP8KL!4?1M\JL[PUL\,2Q@%[>
M9*W2KZ at LXB<F:%X*[N9,W0K5"(?0^0N1GI#!10SFS.!*:B,U at XO1CPG>E6*:
M3<C@*OF.L:C*^$CM;5(&5\E[HQ'_)N7,YO):3(\@,^)9YUX8I4U"R*6,)S^P
M\4W(YBJ%&8I&D4L9463.:DK^%1M+O(UD6`C55TR:4!1`I6GI+`S=O$$Q^4_;
MIJ?`PM\*W<NKXBJJVZU*G"GL19P]^"XNY<)[AQE68P(5??)Y2D_8*.606&B@
MY. at L2`]3EN(C1HE9/+_RX-#3Q@[KQII%1EN,159Z2X[16 at DV\@7AZ8]-2'J[
MV,KR$7['6,RS$[QUB^M=7!+#6L/!6I:PZGJ*G)J@$[- at KB3H9"[-L<MQ1 at MK
M2W+P(KR8,"G3J*A2LAJI85)6+25,&G[[7ER8--JJRZKD<O/.M`\&<S_6G"_O
M3IQ[Y]T+HCD-<LKH-6V'Z;YZ'(6\;XW89R^-X"YZY^+-?PZEEX"T"-K/)WN(
M0U%EG#V+/..NN,U$CK=^IFT8'$XT`/?X5=?T6P,_$>.0F<>_/DS&UXS$#+_A
?<.8O'-K+X&V+IO]68#P6R7RP/_#>_P$",56Y^G4`````
`
end
--
			Gleb.




More information about the U-Boot mailing list