[U-Boot-Users] [patch] corrected comments in cpu_init
Marc Leeman
marc.leeman at barco.com
Fri Jul 23 10:32:09 CEST 2004
The comments in the cpu_init file (concerning the PCI memory accesses)
are corrected (the PPC is _slave_ instead of _master_). In our case, the
DSP is the _master_ and read/writes to the PPC memory over PCI.
-------------- next part --------------
--- u-boot-orig/cpu/mpc824x/cpu_init.c 2004-07-23 10:22:05.000000000 +0200
+++ u-boot/cpu/mpc824x/cpu_init.c 2004-07-23 10:25:04.000000000 +0200
@@ -108,7 +108,7 @@
CONFIG_READ_BYTE(PCMBCR,val);
/* in order not to corrupt data which is being read over the PCI bus
- * with the PPC as master, we need to reduce the number of PCMRBs to 1,
+ * with the PPC as slave, we need to reduce the number of PCMRBs to 1,
* 4.11 in the processor user manual
* */
@@ -117,6 +117,10 @@
#else
CONFIG_WRITE_BYTE(PCMBCR,(val|0x80)); /* 2 PCMRBs */
CONFIG_WRITE_BYTE(PCMBCR,(val|0x40)); /* 3 PCMRBs */
+ /* default, 4 PCMRBs are used, so don't change the
+ * register is this is _really_ what you want: data
+ * corruption with no performance gain
+ */
#endif
#endif
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://lists.denx.de/pipermail/u-boot/attachments/20040723/00d428fb/attachment.pgp
More information about the U-Boot
mailing list