[U-Boot-Users] [PATCH] Small bug fixes for AT91RM9200DK board

[Nicolas Lacressonniere]

OK Wolfgang,

Here is the patch containing only both following fixes (Ethernet
Initialization removed)

- Timings Modifications for SPI DataFlash accesses.
- It fixes a NandFlash Detection problem

Regards.

Nicolas.

-----Original Message-----
From: wd at denx.de [mailto:wd at denx.de]
Sent: vendredi 25 juin 2004 14:41
To: Nicolas Lacressonniere
Cc: u-boot Mailing List; Nicolas Lacressonnière
Subject: Re: [U-Boot-Users] [PATCH] Small bug fixes for AT91RM9200DK
board


In message
<JPEIKMACJJPLJFDEAJEMGEGNIBAA.nicolas.lacressonniere at rfo.atmel.com> you
wrote:
>
> >
> > - It fixes an Ethernet Initialization problem. Now able to start Linux
> > directly from U-Boot without being forced to perform a tffp command
> before.
>
> Rejected.
>
> This is not a problem in U-Boot, but in your Linux driver.  The  rule
> is  that  U-boot  will  initialize  ONLY  that hardware which it uses
> itself, and it may even de-initialize the hardare after use. A  Linux
> driver  must  not  make  any  assumptions about initialization of the
> hardware done or not doen in the boot loader. It  is  resposnible  to
> initialize the hardware to a usable state itself.
>
> >> OK. We will do it differently.
>
> > - Timings Modifications for SPI DataFlash accesses.
> > - It fixes a NandFlash Detection problem
>
> Please split the patch and resubmit only the last 2 items.
> >> Done.
>
> In general, please don't combine unrelated modifications in a  single
> patch.

Sorry, but I cannot parse this message.

Will you please stick to standard quoting rules?

In this message the text that looks  as  if  it  came  from  you  was
actually  my  old  message,  and I am not sure what you typed new, it
anything???


Best regards,

Wolfgang Denk

--
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-4596-87  Fax: (+49)-8142-4596-88  Email: wd at denx.de
The years of peak mental activity are undoubtedly between the ages of
four and eighteen. At four we know all the questions, at eighteen all
the answers.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch_at91rm9200dk.dat
Type: application/octet-stream
Size: 4101 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20040625/e90b54c4/attachment.obj