[U-Boot-Users] pci_hose_read_config_byte() definition puzzles

[Sam Song]

--- Wolfgang Denk <wd at denx.de>wrote:
> > extern void pci_cfgfunc_nothing(struct 
> > pci_controller* hose, pci_dev_t dev,
> > struct pci_config_table *);
> 
> A dummy prototype referenced nowhere in the source
> code?

Yea. I guess there is a mistake. pci_cfgfunc_nothing()
should be pci_cfgfunc_do_nothing() which is defined
in drivers/pci.c. But pci_cfgfunc_do_nothing() is a
dummy one which isn't used at all. Should we remove 
them or just fix it?

> > extern pci_dev_t pci_find_class(int wanted_class, 
> > int wanted_sub_code, int wanted_prog_if, int
> index);
> 
> A dummy prototype referenced nowhere in the active
> source code?

Not quite sure this one:-). grep told me it was used
but where was it's body?!!

[root at sam u-boot-1.1.3]# grep -r pci_find_class ./
./drivers/sk98lin/skge.c:      while((pdev = 
pci_find_class(PCI_CLASS_NETWORK_ETHERNET << 8,pdev)))

./include/pci.h:extern pci_dev_t pci_find_class(int
wanted_class, int wanted_sub_code,

./lib_i386/video_bios.c:    if ((devbusfn = 
pci_find_class(PCI_CLASS_VIDEO,
[root at sam u-boot-1.1.3]#

Best regards,

Sam


		
___________________________________________________________
雅虎免费G邮箱－中国最强免费防毒反垃圾超大邮箱
http://cn.mail.yahoo.com/?id=77072