[U-Boot-Users] byteorder of image_header_t members?

Wolfgang Denk wd at denx.de
Fri Jun 10 16:17:43 CEST 2005


In message <42A97ECC.5030708 at imc-berlin.de> you wrote:
> 
> if uint32_t members of image_header_t are stored in network byteorder, then 
> all references of these members should use ntohl(), right?

Right.

> So should we fix this for instance:
> 
>  >>> cmd_bootm.c:	if (hdr->ih_magic  != IH_MAGIC) {	<<<

Done.

>  >>> cmd_doc.c:		if (hdr->ih_magic == IH_MAGIC) {	<<<
>  >>> cmd_fdc.c:		if (hdr->ih_magic  != IH_MAGIC) {	<<<

Looking forward to see your patch... :-)

Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
As far as the laws of mathematics refer to reality, they are not cer-
tain, and as far as they are certain, they do not refer  to  reality.
                                                   -- Albert Einstein




More information about the U-Boot mailing list