[U-Boot-Users] [PATCH] sinclude board specific make fragment

[Murray.Jensen at csiro.au]

On Thu, 30 Jun 2005 12:17:44 +0200, Wolfgang Denk writes:
>In message <29127.1120109947 at gerd> you wrote:
>> This patch "sinclude"s (i.e. it is allowed not to exist) a make fragment
>> from the board specific subdirectory, to allow a port to have board or
>> platform specific targets (which may or may not be added to ALL var - see
>> previous patch). for example - install, or in the case of my 8560 based
>> board, I build a separate file image of the "boot page". Cheers!
>
>Which problem is this supposed to fix, i. e. why do you need this?

As I said in the description, this allows board specific make targets
such as "install", or other board specific targets that might need to
be included in the $(ALL) make variable.

If make targets are placed in the board specific "config.mk", the first
such target becomes the default make target, instead of "all", which is
declared later in the main Makefile.

>I think  it  is  much more straightfoirward to add the neceessary build
>rules to your board specific Makefile.

make targets placed in the board specific Makefile can't be called from
the top level directory.

>This also avoids  a  slow-down
>of the standard build procedure.

One stat and a bit of text parsing is hardly going to slow things down much.

>CHANGELOG entry missing, too.

Sorry, I didn't know one was needed.

>> The information contained in this e-mail may be confidential or privileged.
>> Any unauthorised use or disclosure is prohibited. If you have received this
>> e-mail in error, please delete it immediately and notify Murray Jensen on
>
>I'm sorry, but I don't think  I  can  include  such  stuff  into  the
>public source tree anyway.

Sigh, we have been over this before, many moons ago. I cannot send email
publically without including the standard disclaimer required by CSIRO,
my employer.

I have been contributing to ppcboot/u-boot for many years now - a lot of my
code is already in there. Since u-boot is GPL code, I am obliged to make my
changes available, and I choose to do this by posting it to this mailing list.

Whether you accept it into the main u-boot cvs repository or not is irrelevant.
As long as people can access the archives of this mailing list, they can access
my changes and therefore I have complied with the spirit of the GPL.

In any case, even though I'd hate to think I was defending these stupid email
disclaimers, by my reading of it, it only says that the information in the
email *may* be "confidential or privileged" - and if so, CSIRO retains all
rights to it. Since this is all GPL code, I can't see how the disclaimer
applies. Cheers!
								Murray...
--
Murray Jensen, CSIRO Manufacturing & Infra. Tech.      Phone: +61 3 9662 7763
Locked Bag No. 9, Preston, Vic, 3072, Australia.         Fax: +61 3 9662 7853
Internet: Murray.Jensen at csiro.au

To the extent permitted by law, CSIRO does not represent, warrant and/or
guarantee that the integrity of this communication has been maintained or
that the communication is free of errors, virus, interception or interference.

The information contained in this e-mail may be confidential or privileged.
Any unauthorised use or disclosure is prohibited. If you have received this
e-mail in error, please delete it immediately and notify Murray Jensen on
+61 3 9662 7763. Thank you.