[U-Boot-Users] PATCH add SMN42 board from Siemens

[Gary Jennejohn]

"Peter Pearse" writes:
>  
> 
> > -----Original Message-----
> > From: u-boot-users-bounces at lists.sourceforge.net 
> > [mailto:u-boot-users-bounces at lists.sourceforge.net] On Behalf 
> > Of Gary Jennejohn
> > Sent: 03 April 2007 18:17
> > To: u-boot-users at lists.sourceforge.net
> > Subject: Re: [U-Boot-Users] PATCH add SMN42 board from Siemens
> > 
> <--- snip --->
> > 
> > But I question whether it's really worth my doing all the 
> > work involved
> > with this change (make the change, test that u-boot still compiles and
> > works and then re-roll the patch) to save a few kB in the tree.
> > 
> That is a decision we all have to make - do we want something that works, or
> something that will be accepted into the main tree?
> 
> Don't forget this will not only save space but also reduce maintenance
> effort.
> 
> If there are two identical files here we have to assume there may be
> elsewhere so every code change involves searching the whole tree for similar
> code...... 
> And perhaps another board will use the same ethernet configuration in the
> future....
> And when we find a bug we have to find all the occurrences.....
> And it encourages others to take the same approach in future.....
> 

Well, I guess I don't have much choice in the matter. Looks like I'll have
to generate a new patch :-(

---
Gary Jennejohn / garyjATjennejohnDOTorg gjATfreebsdDOTorg garyjATdenxDOTde
=====================================================================
DENX Software Engineering GmbH, HRB 165235 Munich, CEO: Wolfgang Denk
Office:  Kirchenstr. 5,       D-82194 Groebenzell,            Germany
=====================================================================