[U-Boot-Users] [PATCH 1/4] emac
Wolfgang Denk
wd at denx.de
Sun Aug 5 22:07:04 CEST 2007
In message <001701c7d792$52efe900$0500a8c0 at monstrone> you wrote:
>
> my patches are below. All patches are in u-boot-microblaze branch.
>
> Signed-off-by: Michal Simek <monstr at monstr.eu>
>
> Emac driver for Microblaze.
NAK.
> fs/jffs2/libjffs2.a \
> - fs/reiserfs/libreiserfs.a fs/ext2/libext2fs.a
> + fs/reiserfs/libreiserfs.a fs/ext2/libext2fs.a fs/romfs/libromfs.a
Please keep lists sorted.
> --- a/drivers/net/xilinx_emac.c
> +++ b/drivers/net/xilinx_emac.c
> @@ -0,0 +1,372 @@
...
> +void eth_halt(void)
> +{
> + return;
> +}
Please see previous mail about coding style issues. These need to be
cleaned up.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
HR Manager to job candidate "I see you've had no computer training.
Although that qualifies you for upper management, it means you're
under-qualified for our entry level positions."
More information about the U-Boot
mailing list