[U-Boot-Users] [PATCH] Fix initrd/dtb interaction
Jerry Van Baren
gvb.uboot at gmail.com
Tue Aug 14 05:05:42 CEST 2007
Wolfgang Denk wrote:
> Dear Andy,
>
> in message <11870460962397-git-send-email-afleming at freescale.com> you wrote:
>> The original code would wrongly relocate the blob to be right before
>> the initrd if it existed. The blob *must* be within CFG_BOOTMAPSZ,
>> if it is defined. So we make two changes:
>>
>> 1) flag the blob for relocation whenever its address is above BOOTMAPSZ
>>
>> 2) If the blob is being relocated, relocate it before kbd, not initrd
>>
>> Signed-off-by: Andy Fleming <afleming at freescale.com>
>
> NAK.
>
>
> I'm afraid I have to reject this patch.
>
>
>> diff --git a/common/cmd_bootm.c b/common/cmd_bootm.c
>> index 2436581..580a9f0 100644
>> --- a/common/cmd_bootm.c
>> +++ b/common/cmd_bootm.c
>> @@ -21,6 +21,7 @@
>> * MA 02111-1307 USA
>> */
>>
>> +#define DEBUG
>
> First, please don't enable DEBUG like this in common files.
Agree with this comment.
>> +#ifdef CFG_BOOTMAPSZ
>> + /*
>> + * The blob must be within CFG_BOOTMAPSZ,
>> + * so we flag it to be copied if it is
>> + */
>> + if (of_flat_tree >= (char *)CFG_BOOTMAPSZ)
>> + of_data = of_flat_tree;
>> +#endif
>> +
[snip]
>
> Second, I asked you before to implement this similar like the initrd
> location can be controlled using the "initrd_high" environment
> variable (see my message Tue, 07 Aug 2007 21:21:19 +0200). AFAICT you
> never replied to this.
I believe Andy got this from me. I keyed off his statement that "The
blob must be within CFG_BOOTMAPSZ..." so I suggested he compare
of_flat_tree to CFG_BOOTMAPSZ, since that was the criteria that he stated.
<http://comments.gmane.org/gmane.comp.boot-loaders.u-boot/30616>
I'm ignorant of the particulars, but I assumed from the above referenced
discussion/description that CFG_BOOTMAPSZ is a better criteria than
initrd_high. True? False?
> Best regards,
>
> Wolfgang Denk
Best regards,
gvb
More information about the U-Boot
mailing list