[U-Boot-Users] [PATCH] mpc83xx: fix alternate build dir location problem with pq-mds-pib.o

[Wolfgang Denk]

Dear Kim,

in message <20070820114546.81c4f667.kim.phillips at freescale.com> you wrote:
> fixes this build error:
> 
> FATAL: can't create /work/wd/tmp/u-boot-ppc/board/freescale/mpc8360emds/../common/pq-mds-pib.o: No such file or directory
> 
> Signed-off-by: Kim Phillips <kim.phillips at freescale.com>
> ---
>  board/freescale/mpc832xemds/Makefile |    4 ++++
>  board/freescale/mpc8360emds/Makefile |    4 ++++
>  2 files changed, 8 insertions(+), 0 deletions(-)
> 
> diff --git a/board/freescale/mpc832xemds/Makefile b/board/freescale/mpc832xemds/Makefile
> index ea52484..3215c3d 100644
> --- a/board/freescale/mpc832xemds/Makefile
> +++ b/board/freescale/mpc832xemds/Makefile
> @@ -23,6 +23,10 @@
>  
>  include $(TOPDIR)/config.mk
>  
> +ifneq ($(OBJTREE),$(SRCTREE))
> +$(shell mkdir -p $(obj)../common)
> +endif
> +
>  LIB	= $(obj)lib$(BOARD).a
>  
>  COBJS	:= $(BOARD).o pci.o ../common/pq-mds-pib.o
> diff --git a/board/freescale/mpc8360emds/Makefile b/board/freescale/mpc8360emds/Makefile
> index ea52484..3215c3d 100644
> --- a/board/freescale/mpc8360emds/Makefile
> +++ b/board/freescale/mpc8360emds/Makefile
> @@ -23,6 +23,10 @@
>  
>  include $(TOPDIR)/config.mk
>  
> +ifneq ($(OBJTREE),$(SRCTREE))
> +$(shell mkdir -p $(obj)../common)
> +endif
> +
>  LIB	= $(obj)lib$(BOARD).a
>  
>  COBJS	:= $(BOARD).o pci.o ../common/pq-mds-pib.o

I'm not exactly happy about having this snippet of code now in each
and every board Makefile. 

Instead, there should be a proper Makefile in board/freescale/common/
which also takes care of that.

What do you think?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Forty two.