[U-Boot-Users] [PATCH] mpc83xx: add command line editing by default

Wolfgang Denk wd at denx.de
Fri Feb 16 12:23:06 CET 2007


In message <528646bc0702151722xc107d6fq4a388265002c5bd2 at mail.gmail.com> you wrote:
>
> > Are you the maintainer of the sbc8349 baord?
> >
> > Did you discuss such a change with the maintainer?
> 
> Ummm... Isn't that what this mailing list is for?  To discuss changes?

Yes, but there is different types of changes.

There is no need to discuss a bug fix - it should always be applied to
all affected boards, of course.

But this is not a bug fix - it is a change of  the  board  configura-
tion, i. e. of the board customization. I think it is NOT a good idea
if  anybody  meddles  with  the  configuration of someone elses board
without  discussing  this  explicitely  with  the  respective   board
maintainer.  In  the  current  case,  it was totally unclear to me if
"foreign" boards would be changed, or not.

As a complication there is the problem that this patch does not  even
apply  to  the current U-Boot tree, which does not contain such files
like include/configs/MPC832XEMDS.h or include/configs/sbc8349.h;  and
the  patch  did  not contain any indication which tree it was against
and/or which previous patches it requires.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, HRB 165235 Munich, CEO: Wolfgang Denk
Office:  Kirchenstr. 5,       D-82194 Groebenzell,            Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I can't understand it. I can't even understand  the  people  who  can
understand it.                    - Queen Juliana of the Netherlands.




More information about the U-Boot mailing list