[U-Boot-Users] environment settings question

nicky geerts nicky.geerts.news at gmail.com
Tue Jun 26 09:40:42 CEST 2007


grep -r CFG_ENV_IS_IN_FLASH * | grep if

it does show that CFG_ENV_IS_IN_FLASH is checked to be '1' in some
custom board flash drivers

your safest bet would be the second option, although I agree with
Timur Tabi that it isn't really logical.

2007/6/26, Timur Tabi <timur at freescale.com>:
> sapirf fersht wrote:
> > For a ixp425 cpu how should the environment value
> > #define CFG_ENV_IS_IN_FLASH be set?
> >
> > #define CFG_ENV_IS_IN_FLASH
> >
> > OR
> >
> > #define CFG_ENV_IS_IN_FLASH 1
>
> The code that uses these macros should support both methods, but personally I prefer that
> the macros themselves be defined using the first method.  IMHO, you should define a macro
> to contain a value only if that value has some inherent significance.  For example, does
> "1" really mean something that "2" doesn't?  In this case, no.
>
> --
> Timur Tabi
> Linux Kernel Developer @ Freescale
>
> -------------------------------------------------------------------------
> This SF.net email is sponsored by DB2 Express
> Download DB2 Express C - the FREE version of DB2 express and take
> control of your XML. No limits. Just data. Click to get it now.
> http://sourceforge.net/powerbar/db2/
> _______________________________________________
> U-Boot-Users mailing list
> U-Boot-Users at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/u-boot-users
>




More information about the U-Boot mailing list