[U-Boot-Users] [GIT-PULL][Blackfin] Please pull http://www.denx.de/git/u-boot-blackfin.git

[Aubrey Li]

On 3/10/07, Wolfgang Denk <wd at denx.de> wrote:
> Dear Aubrey,
>
> in message <27d85ee10703082203m74822868i5d3fe6fd0eaa269a at mail.gmail.com> you wrote:
> > The following changes since commit eb92f613556800f7483666db09d9a237ad911d4a:
> >
> > Aubrey.Li (2)
> >     [Patch 1/2] Remove obsolete blackfin port and add bf533 platform support
>
> Sorry, but I have to reject to merge the current version.
>
>
>
> Commit 3f0606ad0b5639f7f22848fe5b4574e754d0470f breaks building in
> other directories, i.e. changes like this one are bad and need to be
> fixed:
>
> board/bf533-ezkit/Makefile:
>
>
> -LIB    = $(obj)lib$(BOARD).a
> +LIB    = lib$(BOARD).a
> ...
> -SRCS   := $(SOBJS:.o=.S) $(COBJS:.o=.c)
> -OBJS   := $(addprefix $(obj),$(COBJS))
> -SOBJS  := $(addprefix $(obj),$(SOBJS))
> +$(LIB):        .depend $(OBJS) u-boot.lds
> +       $(AR) cr $@ $(OBJS)
>
> -$(LIB):        $(obj).depend $(OBJS)
> -       $(AR) $(ARFLAGS) $@ $(OBJS)
> +u-boot.lds: u-boot.lds.S
> +       $(CPP) $(CPPFLAGS) -P -Ubfin $^ > $@.tmp
> +       mv -f $@.tmp $@
>
> etc.
>
> The same is happens in other Makefiles.

I'm trying to replicate the issue you pointed out, but I got the
following error.
I guess I'm using the out-of-date toolchain. What arm toolchain are you using?
==============================================
aubrey at ubuntu-feisty:~/upstream-uboot/u-boot-test$ git-branch
  dzu at denx.de
  master
  origin
  testing-4xx_enet
  testing-NAND
  testing-USB
* wd at denx.de
aubrey at ubuntu-feisty:~/upstream-uboot/u-boot-test$ arm-linux-gcc -v
Reading specs from
/home/aubrey/upstream-uboot/usr/local/arm/3.4.1/bin/../lib/gcc/arm-linux/3.4.1/specs
Configured with:
/work/crosstool-0.27/build/arm-linux/gcc-3.4.1-glibc-2.3.2/gcc-3.4.1/configure
--target=arm-linux --host=i686-host_pc-linux-gnu
--prefix=/usr/local/arm/3.4.1
--with-headers=/usr/local/arm/3.4.1/arm-linux/include
--with-local-prefix=/usr/local/arm/3.4.1/arm-linux --disable-nls
--enable-threads=posix --enable-symvers=gnu --enable-__cxa_atexit
--enable-languages=c,c++ --enable-shared --enable-c99
--enable-long-long
Thread model: posix
gcc version 3.4.1
aubrey at ubuntu-feisty:~/upstream-uboot/u-boot-test$
CROSS_COMPILE=arm-linux- ./MAKEALL arm
Configuring for assabet board...
lib_arm/libarm.a(_udivsi3.o)(.text+0x8c):/home/aubrey/upstream-uboot/u-boot-test/lib_arm/_udivsi3.S:67:
relocation truncated to fit: R_ARM_PLT32 __div0
lib_arm/libarm.a(_umodsi3.o)(.text+0xa8):/home/aubrey/upstream-uboot/u-boot-test/lib_arm/_umodsi3.S:79:
relocation truncated to fit: R_ARM_PLT32 __div0
make: *** [u-boot] Error 1
arm-linux-size: './u-boot': No such file
=====================================================

Well, MAKEALL blackfin has no building problem. I still don't
understand why blackfin Makefile can make arm building fails. They are
different architecture, they were supposed to not impact each other.
If that's true, Can I report a u-boot bug?

>
>
> Also, turning back Copyright entries is a Bad Thing, too.
>
>
> Also, there is a LOT of Coding Style problems:
>
> C++ comments in ./include/asm-blackfin/arch-bf533/defBF532.h,
> ./include/asm-blackfin/arch-common/cdef_LPBlackfin.h,
> ./include/configs/bf533-ezkit.h, ./include/configs/bf533-stamp.h
>
> Trailing white space in ./cpu/bf533/bf533_serial.h,
> ./cpu/bf533/cache.S, ./cpu/bf533/flush.S, ./cpu/bf533/init_sdram.S,
> ./cpu/bf533/init_sdram_bootrom_initblock.S, ./cpu/bf533/interrupt.S,
> ./cpu/bf533/start.S, ./cpu/bf533/traps.c, ./cpu/bf533/video.c
>
> Indentation not by TABs at least in
> ./cpu/bf533/init_sdram_bootrom_initblock.S, ./cpu/bf533/start.S,
> ,./include/asm-blackfin/arch-bf533/anomaly.h
> ./include/asm-blackfin/mem_init.h, ./include/configs/bf533-ezkit.h,
> ./include/configs/bf533-stamp.h
>
> Too many empty lines in ./lib_blackfin/memcpy.S
>
> Trailing empty lines in ./board/bf533-ezkit/u-boot.lds.S,
> ./board/bf533-stamp/u-boot.lds.S, ./cpu/bf533/init_sdram.S,
> ./cpu/bf533/init_sdram_bootrom_initblock.S
>

As my latest commit and git push, I think copyright and coding style
issues should be fixed. Please let me know if there still has any
problems. Thanks a lot.

Best Regards,
-Aubrey