[U-Boot-Users] [PATCH] patch for rtl8139.c, base version is u-boot-1.1.6

[Wolfgang Denk]

Dear Lucas,

in message <200710122232229680490 at gmail.com> you wrote:
> 
> --- ./drivers/rtl8139.c.orig	2007-10-12 22:17:52.000000000 +0800
> +++ ./drivers/rtl8139.c	2007-10-12 22:39:21.170169464 +0800

I have to reject this patch.

* There is no description at all which problem this patch is supposed
  to fix or what else it does

* Signed-off-by line is missing

Please see http://www.denx.de/wiki/UBoot/Patches for instructions.

> @@ -254,8 +255,9 @@
>  	outb(0x00, ioaddr + Config1);
>  
>  	addr_len = read_eeprom(0,8) == 0x8129 ? 8 : 6;
> -	for (i = 0; i < 3; i++)
> -		*ap++ = le16_to_cpu (read_eeprom(i + 7, addr_len));
> +	//this doesn't work
> +	//for (i = 0; i < 3; i++)
> +	//	*ap++ = le16_to_cpu (read_eeprom(i + 7, addr_len));

First: C++ comments are not allowed in U-Boot, see
http://www.denx.de/wiki/UBoot/CodingStyle

Second: if it doesn't work, please fix it. Simply removing this is
probably a bad idea.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"I haven't lost my mind - it's backed up on tape somewhere."