[U-Boot-Users] [Patch] Make MPC8266ADS compile again

Wolfgang Denk wd at denx.de
Tue Oct 16 22:33:36 CEST 2007


In message <471518AF.8080509 at ge.com> you wrote:
>
> The *proper* fix is to delete the
> #include <config_cmd_all.h>
> and #define only the commands that actually are desired.

Hm...

> The simplest (and probably most proper) way to do this is actually to
> #include <config_cmd_default.h>
> and then add non-default commands that may be useful on the MPC8266ADS 
> board.

Indeed, that's the preferred way for 99% of all situations.

> The current configuration is legacy from the old bit-mapped 
> configuration ways plus a very poor choice to do the "all-subtractive" 
> method of selecting commands.
> 
> With the "all-subtractive" method, new commands will *FOREVER* be 
> breaking the board, resulting in patches and/or bit rot forever.  Please 
> fix it once, right, and we will all thank you forever.

Agreed.


Nevertheless, the patch fixes a real build problem now, so I'll apply
it.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Q: How do you spell "onomatopoeia"?
A: The way it sounds.




More information about the U-Boot mailing list