[U-Boot-Users] [PATCH 3/3] ppc4xx: Change Canyonlands to support booting from 2k page NAND devices

Wolfgang Denk wd at denx.de
Tue Apr 8 14:03:58 CEST 2008


In message <200804081352.01473.sr at denx.de> you wrote:
>
> > > +#if 0
> > > +/*
> > > + * Values for 512 page size NAND chips, not used anymore, just
> > > + * keep them here for reference
> > > + */
> >
> > Please don't add dead code.
> 
> I was unsure about this, and kept it in as a reference for 460EX/GT boards 
> using 512 page size NAND chips (see comment above). Such a reference is quite 
> valuable from my point of view.
> 
> How should I keep such code available?

If it's intended as documentation, it should be such - i. e. either in
some README file, or as part of some comment.

But I understanmd your argument, and you have to work more with  this
code then me - so please decide as you feel appropriate.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Anything that is worth doing at all is worth doing well.
                                       -- Philip Earl of Chesterfield




More information about the U-Boot mailing list