[U-Boot-Users] Xilinx PowerPC XPS_LL_TEMAC driver

Wolfgang Denk wd at denx.de
Sat Apr 26 09:43:33 CEST 2008


In message <JN200804261159205.13431171 at co-nss.co.jp> you wrote:
> 
> I corrected some faults and checked normal operation by EDK10.1.
> 
> Best Regards,
> 
> Yoshio Kashiwagi - Nissin Systems

If this is supposed to be a patch submission, then please
don't forget to add your Signed-off-by line


> diff --git a/drivers/net/xilinx_ll_temac.c b/drivers/net/xilinx_ll_temac.
> c
^^^^^^^^^^^^^
> new file mode 100644
> index 0000000..2f75ebc
> --- /dev/null
> +++ b/drivers/net/xilinx_ll_temac.c
> @@ -0,0 +1,371 @@
> +/*
> + *
> + * Xilinx xps_ll_temac ethernet driver for u-boot
> + *
> + * Author: Yoshio Kashiwagi kashiwagi at co-nss.co.jp
> + *
> + * Copyright (c) 2008 Nissin Systems Co.,Ltd.
> + *
> + * March 2008 created
> + *
> + * This program is free software; you can redistribute it and/or modify 
> it
^^^^^^^^^^^^^
> + * under  the terms of the GNU General  Public License as published by 
> the
^^^^^^^^^^^^^
> + * Free Software Foundation;  either version 2 of the  License, or (at 
> your
^^^^^^^^^^^^^

Patch was corrupted by your mailer (line wrapping).

...
> +/* SDMA Buffer Descriptor */
> +
> +typedef struct cdmac_bd_t {
> +   struct cdmac_bd_t *next_p;
> +   unsigned char *phys_buf_p;
> +   unsigned long buf_len;
> +   unsigned char stat;
> +   unsigned char app1_1;
> +   unsigned short app1_2;
> +   unsigned long app2;
> +   unsigned long app3;
> +   unsigned long app4;
> +   unsigned long app5;
> +} cdmac_bd __attribute((aligned(32))) ;

Indentation by TAB please (here and everywhere - please heed the
Coding Style requirements, see
http://www.denx.de/wiki/UBoot/CodingStyle

Please cleanup, fix your mailer, add a s-o-b line and resubmit.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
There are two kinds of people, those who do the work  and  those  who
take  the  credit.  Try  to  be  in  the  first  group; there is less
competition there.                                    - Indira Gandhi




More information about the U-Boot mailing list