[U-Boot-Users] [PATCH v2] smc911x: add 16 bit support

Wolfgang Denk wd at denx.de
Wed Apr 30 23:31:54 CEST 2008


In message <f8328f7c0804301426q1b3a0f54ief2c78722ce1419 at mail.gmail.com> you wrote:
>
> Almost there.  This comment needs to go below the '---' line so that
> it doesn't become part of the commit message.  Also, please add a

That's correct.

> meaningful comment here (above your SOB line).  The patch title
> contains all the useful information, so you may want to just copy it,
> but there needs to be something.

No, please don't, or the line will end up twice in the commit message.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Quote from the Boss... "I didn't say it was your fault.  I said I was
going to blame it on you."




More information about the U-Boot mailing list