[U-Boot] [PATCH] tsec: report when there is no vendor specific PHY support.

Andy Fleming afleming at freescale.com
Thu Dec 11 22:17:16 CET 2008


On Dec 11, 2008, at 2:29 PM, Paul Gortmaker wrote:

> Commit af1c2b84 added a generic phy support, with an ID of zero
> and a 32 bit mask; meaning that it will match on any PHY ID.
>
> The problem is that there is a test that checked if a matching
> PHY was found, and if not, it printed the non-matching ID.
> But since there will always be a match (on the generic PHY,
> worst case), this test will never trip.
>
> In the case of a misconfigured PHY address, or of a PHY that
> isn't explicitly supported outside of the generic support,
> you will never see the ID of 0xffffffff, or the ID of the
> real (but unsupported) chip.  It will silently fall through
> onto the generic support.
>
> This change makes that test useful again, and ensures that
> the selection of generic PHY support doesn't happen without
> some sort of notice.  It also makes it explicitly clear that
> the generic PHY must be last in the PHY table.
>
> Signed-off-by: Paul Gortmaker <paul.gortmaker at windriver.com>

Acked-by: Andy Fleming <afleming at freescale.com>



More information about the U-Boot mailing list