[U-Boot-Users] unassigned-patches/6: [PATCH] Add include for config.h in command.h.

u-boot at bugs.denx.de u-boot at bugs.denx.de
Fri Jul 25 01:25:01 CEST 2008


 Because the cmd_tbl_s structure depends on the configuration file,
 it must be assured that config.h is included before the structure is
 evaluated by the compiler. If this is not certain, it could happen
 that the compiler generates structures of different size, depending
 on the fact if the source file includes <config.h> before or after
 <command.h>.
 The effect is that u-boot crashes when tries to relocate the command
 table (for ppc) or try to access to the command table for other
 architectures.
 The problem can happen on board-depending commands.All general
 commands under /common are unaffected, because they include already
 config.h before command.h.

Signed-off-by: Stefano Babic <sbabic at denx.de>

---
Added to GNATS database as unassigned-patches/6
>Responsible:    patch-coord
>Message-Id:     <1216909345-15346-1-git-send-email-sbabic at denx.de>
>In-Reply-To:    <>
>References:     <>
>Patch-Date:     Thu Jul 24 16:22:25 +0200 2008
---
 include/command.h |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/include/command.h b/include/command.h
index c3ef51d..8815937 100644
--- a/include/command.h
+++ b/include/command.h
@@ -31,6 +31,8 @@
 #define NULL	0
 #endif
 
+#include <config.h>
+
 #ifndef	__ASSEMBLY__
 /*
  * Monitor Command Table
-- 
1.5.4.3


-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
U-Boot-Users mailing list
U-Boot-Users at lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users







More information about the U-Boot mailing list