[U-Boot-Users] [PATCH 1/1] Re-Submit: Add support for ATMEL AT91SAM9G20EK board.

[Ben Warren]

On Tue, Jul 29, 2008 at 2:15 AM, Haavard Skinnemoen
<haavard.skinnemoen at atmel.com> wrote:
> "Hong Xu" <hongxu.cn at gmail.com> wrote:
>> >> or something like this.  I don't know if AT91_BASE_EMAC is visible
>> >> from this code, so you may need to modify slightly.
>> > Can we do a cpu_eth_init instead?
>> Not all arm926ejs series have built-in ethernet controller (e.g.
>> AT91SAM9261 does not have). If we do it in cpu_eth_init, we may need
>> other more #ifdef_s to distinguish. :-)
>
> In _my_ opinion, I think it's much cleaner to just let the board code
> decide which and how many ethernet controllers to initialize instead of
> having some #ifdef maze in the CPU code. But it's not may call.
>
Agreed
> Oh, and another thing...
>
>> >> extern int macb_eth_initialize(int id, void *regs, unsigned int phy_addr);
>
> We're getting more and more of these. Does anyone know an appropriate
> header to put it in?
>
At one point I had a netdev.h file, but removed it because it only
contained this type of definition.  Maybe it's time to resurrect.

regards,
Ben