[U-Boot-Users] Pull request u-boot-blackfin.git

Mike Frysinger vapier at gentoo.org
Mon Jun 2 00:47:43 CEST 2008


On Sunday 01 June 2008, Wolfgang Denk wrote:
> In message <200806011802.41546.vapier at gentoo.org> you wrote:
> > > I expect that the entry in the pull request match the subject of some
> > > posting. Is this not the case? If so, why not?
> >
> > i really have no idea what you're referring to
>
> You wrote:
>
> Mike Frysinger (14):
>       Blackfin: make baud calculation more accurate
>       Blackfin: fix up UART status bit handling
>       Blackfin: fix up comment about CONFIG_BFIN_BOOT_MODE
>       Blackfin: punt unused page_descriptor_table_size definition
>       Blackfin: punt mem_init.h since it is no longer used
>       Blackfin: update cpu header definitions from latest Blackfin
> toolchain Blackfin: punt unused BF533-STAMP definitions
>       Blackfin: resurrect BF533-STAMP video splash driver
>       Blackfin: touchup BF561-EZKIT board file
>       Blackfin: set default boot SPI CS for BF538/BF539
>       Blackfin: kill conversion warnings in async nand driver
>       Blackfin: tighten up post memory coding style
>       Blackfin: overhaul i2c driver
>       Blackfin: implement go/boote wrappers
>
> I can find the subjects
>
> 	overhaul i2c driver
> and	implement go/boote wrappers
>
> in my archive.
>
> I cannot find any of the other subjects. For example,  where  is  any
> posting that contained the string
>
> 	fix up comment about CONFIG_BFIN_BOOT_MODE

i can find them just fine with the same exact subject as well as your replies.  
dont know what to tell you.

> > > > i implemented his suggestions
> > >
> > > You did not repost a cleaned up patch?
> >
> > to "fix" whitespace ?  no, i didnt
>
> So how should anybody know if this is the old patch, or  if  you  did
> any changes, and if so, which changes you did?

you have all the source in the open.  there's no secrets.  if you dont trust 
me, you can check things by running `diff`.

> We don't want to pull unreviewed code.

for things that are substantial, reposting makes sense.  you want to see 
reposts of only whitespace changes ?

> > > So the status quo is that I rejected this patch. Why do you think you
> > > could it add to the repo?
> >
> > you rejected based on a misunderstanding of what the purpose of the
> > change
>
> This is your opinion. Fact is, that I rejected  it,  and  I  did  not
> revert this reject, and I do not revert it now.

then follow up with what needs to happen.  your proposals in the thread werent 
a solution to the problem at hand and you've rejected anything ive tried to 
do to appease you.

> Actually it is pretty foul game to try and  make  me  pull  in  stuff
> which I explicitely rejected.

please refrain from such irrelevant comments
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20080601/53797c89/attachment.pgp 


More information about the U-Boot mailing list