[U-Boot-Users] [Patch 11/17 Try 2] U-Boot-V2:ARM:OMAP3: Add support for OMAP3Silicon files

Menon, Nishanth x0nishan at ti.com
Tue Jun 3 17:36:05 CEST 2008


Sascha,
> -----Original Message-----
> From: Sascha Hauer [mailto:s.hauer at pengutronix.de]
> Sent: Tuesday, June 03, 2008 3:18 AM
> To: Menon, Nishanth
> Cc: Peter Pearse; u-boot-users at lists.sourceforge.net; Kamat, Nishant; Syed Mohammed, Khasim; Laurent
> Desnogues; philip.balister at gmail.com
> Subject: Re: [Patch 11/17 Try 2] U-Boot-V2:ARM:OMAP3: Add support for OMAP3Silicon files
> 
> On Wed, May 28, 2008 at 10:39:07AM -0500, Menon, Nishanth wrote:
> > As per the thread in:
> > http://www.nabble.com/-Patch-06-17--U-Boot-V2%3AARM%3A-Add-sizes.h-tt17372780.html#a17372780
> > sizes.h dependency is removed from the following patch. This is a resubmission.
> >
> > This patch introduces support for OMAP3430 - provides for generic OMAP3 files.
> 
> Looks ok to me besides the occurences of return with the value in
> brackets.
> 
> Sascha
Arrgh.. I have myself to blame for inconsistent return styles. Probably we need an equivalent of checkpatch and a Lindent for U-Boot v2? I suppose the right style is return without brackets?

Regards,
Nishanth Menon




More information about the U-Boot mailing list