[U-Boot-Users] [patch] DM9000 fix status check fail 0x6d error for trizeps board

Ben Warren biggerbadderben at gmail.com
Fri Jun 6 08:54:29 CEST 2008


On Thu, Jun 5, 2008 at 4:03 AM, Remy Bohmer <linux at bohmer.net> wrote:
> According to the Application Notes of the DM9000, only the 2 bits 0:1 of
> the status byte need to be checked to identify a valid packet in the fifo
>
> But, The several different Application Notes do not all speak the same
> language on these bits. They do not disagree, but only 1 Application Note
> noted explicitly that only these 2 bits need to be checked.
> Even the datasheets do not mention anything about these 2 bits.
>
> Because the old code, and the kernel check the whole byte, I left this piece
> untouched.
>
> However, I tested all board/DM9000[A|E|EP] devices with this 2 bit check, so
> it should work.
>
> Notice, that the 2nd iteration through this receive loop (when a 2nd packet is
> in the fifo) is much shorter now, compared to the older U-boot driver code,
> so that we can maybe run into a hardware condition now that was never seen
> before, or maybe was seen very unfrequently.
>
> Additionaly added a cleanup of a stack variable.
>
> Signed-off-by: Remy Bohmer <linux at bohmer.net>
>
>

Applied to net repo.  Thanks!

Stefano, please test from the net repo if you can on your Trizeps board.

regards,
Ben




More information about the U-Boot mailing list