[U-Boot-Users] [RFC/PATCH] fix initdram / use of phys_addr_t

Wolfgang Denk wd at denx.de
Wed Mar 12 19:40:21 CET 2008


Dear Kumar,

in message <Pine.LNX.4.64.0803121037440.13065 at blarg.am.freescale.net> you wrote:
> 
> The idea is that initdram() should really have returned a 'unsigned long'.
> However if we are going to change everyone that has initdram I figure we
> should make it return a phys_addr_t.

Um, no, I don't think so.

> +phys_addr_t initdram(int board_type)
>  {
> -	long dram_size = 0;
> +	phys_addr_t dram_size = 0;

No - initdram() does not return an address, it returns a size.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"There is nothing new under the sun, but there are lots of old things
we don't know yet."                                  - Ambrose Bierce




More information about the U-Boot mailing list