[U-Boot-Users] [PATCH 4/8] SPARC: Added SPARC board information to bdinfo command

[Wolfgang Denk]

In message <47D8F63C.6010002 at gaisler.com> you wrote:
> This patch adds support for the U-Boot command 'bdinfo' for SPARC boards,
> the output is as shown below.
...
> diff --git a/common/cmd_bdinfo.c b/common/cmd_bdinfo.c
> index bbb0192..838c103 100644
> --- a/common/cmd_bdinfo.c
> +++ b/common/cmd_bdinfo.c
> @@ -208,6 +208,40 @@ int do_bdinfo ( cmd_tbl_t *cmdtp, int flag, int 
> argc, char *argv[])
>      return 0;
>  }
>  
> +#elif defined(CONFIG_SPARC)   /* SPARC */
> +int do_bdinfo ( cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
> +{
> +    bd_t *bd = gd->bd;
> +#if defined(CONFIG_CMD_NET)
> +    int i;
> +#endif
> +
> +#ifdef DEBUG
> +    print_num ("bd address             ",(ulong)bd);
> +#endif
> +    print_num ("memstart               ",bd->bi_memstart);
> +    print_num ("memsize                ",bd->bi_memsize);
> +    print_num ("flashstart             ",bd->bi_flashstart);
> +    print_num ("CFG_MONITOR_BASE       ",CFG_MONITOR_BASE);
> +    print_num ("CFG_ENV_ADDR           ",CFG_ENV_ADDR);
> +    printf ("CFG_RELOC_MONITOR_BASE = 0x%lx 
> (%d)\n",CFG_RELOC_MONITOR_BASE,CFG_MONITOR_LEN);
> +    printf ("CFG_MALLOC_BASE        = 0x%lx 
> (%d)\n",CFG_MALLOC_BASE,CFG_MALLOC_LEN);
> +    printf ("CFG_INIT_SP_OFFSET     = 0x%lx 
> (%d)\n",CFG_INIT_SP_OFFSET,CFG_STACK_SIZE);
> +    printf ("CFG_PROM_OFFSET        = 0x%lx 
> (%d)\n",CFG_PROM_OFFSET,CFG_PROM_SIZE);
> +    printf ("CFG_GBL_DATA_OFFSET    = 0x%lx 
> (%d)\n",CFG_GBL_DATA_OFFSET,CFG_GBL_DATA_SIZE);

The patch is line-wrapped and thus unusable, and you have again lots
of coding style issues.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"The value of marriage is not that adults produce children, but  that
children produce adults."                            - Peter De Vries