[U-Boot] [PATCH 02/13 v5] ARM: OMAP3: Add i2c, memory, omap3 and function prototype headers

[Wolfgang Denk]

Dear dirk.behme at googlemail.com,

In message <490df2f4.0637560a.4984.2258 at mx.google.com> you wrote:
> Subject: [PATCH 02/13 v5] ARM: OMAP3: Add i2c, memory, omap3 and function prototype headers
> 
> From: Dirk Behme <dirk.behme at gmail.com>
> 
> Add i2c, memory, omap3 and function prototype headers
> 
> Signed-off-by: Dirk Behme <dirk.behme at gmail.com>
...

> +/* Stuff on L3 Interconnect */
> +#define SMX_APE_BASE			0x68000000
> +
> +/* GPMC */
> +#define OMAP34XX_GPMC_BASE		(0x6E000000)
> +
> +/* SMS */
> +#define OMAP34XX_SMS_BASE		0x6C000000

Please use a consistent style. Plain numbers don't need parens, so why
does OMAP34XX_GPMC_BASE neeed them?

...
> +#define OMAP34XX_GPT11			0x48088000
> +#define OMAP34XX_GPT12			0x48304000
> +
> +/* WatchDog Timers (1 secure, 3 GP) */
> +#define WD1_BASE			(0x4830C000)
> +#define WD2_BASE			(0x48314000)
> +#define WD3_BASE			(0x49030000)
> +
> +/* 32KTIMER */
> +#define SYNC_32KTIMER_BASE		(0x48320000)

Ditto.

[and so on.]


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"The  release  of  emotion  is  what  keeps  us  health.  Emotionally
healthy."
"That may be, Doctor. However, I have noted that the healthy  release
of emotion is frequently unhealthy for those closest to you."
	-- McCoy and Spock, "Plato's Stepchildren", stardate 5784.3