[U-Boot] [PATCH] i2c: merge all i2c_reg_read() and i2c_reg_write() into inline functions

Timur Tabi timur at freescale.com
Mon Oct 6 05:25:11 CEST 2008


Mike and Cliff,

This I2C patch converts some I2C functions t inline, but in the case
of blackfin and pxa, it removes the PRINTD() call as well.  If you're
okay with that, please ACK this patch.

You can find the original patch in the mailing list archive here:
http://lists.denx.de/pipermail/u-boot/2008-October/041173.html

On Thu, Oct 2, 2008 at 10:06 AM, Timur Tabi <timur at freescale.com> wrote:
> All implementations of the functions i2c_reg_read() and i2c_reg_write() are
> identical.  We can save space and simplify the code by converting these
> functions into inlines and putting them in i2c.h.
>
> Signed-off-by: Timur Tabi <timur at freescale.com>
> ---
>
> I'm posting this patch because I'm enhancing the I2C routines to support
> multiple I2C busses more easily, but I need to clean up the existing code
> first.
>
>  cpu/arm920t/at91rm9200/i2c.c  |   14 --------------
>  cpu/arm926ejs/davinci/i2c.c   |   17 -----------------
>  cpu/blackfin/i2c.c            |   16 ----------------
>  cpu/mpc512x/i2c.c             |   17 -----------------
>  cpu/mpc5xxx/i2c.c             |   16 ----------------
>  cpu/mpc8220/i2c.c             |   16 ----------------
>  cpu/mpc824x/drivers/i2c/i2c.c |   14 --------------
>  cpu/mpc8260/i2c.c             |   16 ----------------
>  cpu/mpc8xx/i2c.c              |   20 --------------------
>  cpu/ppc4xx/i2c.c              |   20 --------------------
>  cpu/pxa/i2c.c                 |   15 ---------------
>  drivers/i2c/fsl_i2c.c         |   16 ----------------
>  drivers/i2c/soft_i2c.c        |   19 -------------------
>  include/i2c.h                 |   15 +++++++++++++--
>  14 files changed, 13 insertions(+), 218 deletions(-)

-- 
Timur Tabi
Linux kernel developer at Freescale


More information about the U-Boot mailing list