[U-Boot] [PATCH] Olimex SAM9-L9260 board support

[Wolfgang Denk]

Dear Cristian,

In message <597eb9790810070935u7d1713eat496c0288f629c8a3 at mail.gmail.com> you wrote:
> 
> I tried to include the common.h file in my configuration file but this
> breaks u-boot compilation (it's
> not safe to include common.h standalone) .I noticed that none of other

What do you mean by "include common.h standalone" ?

> board configuration files
> include common.h

Normally it's not needed, because all files where the board config
file will be used also include common.h.

> If I replace the ROUND(A,B) macro with #define DIV_ROUND_UP(n,d) (((n)
> + (d) - 1) / (d))
> macro when i try to make u-boot I obtain the following errors:
> 
> start.S: Assembler messages:
> start.S:339: Error: invalid constant (802d) after fixup

So what does this source line look like in you version of the code?

802d = 0x802d = 32813 looks wrong to me. PLease check wht the code is
doing there. There might be a (hidden) bug somewhere.

> It appears to me that the solution for the moment is to use the following fixed
> macro:
> 	define ROUND(A, B)		(((A) + (B) -1) & ~((B) - 1))

Nevertheless check what your code in start.S is doing.

> I removed the reset_phy() function and I do not use anymore CONFIG_RESET_PHY_R.
> I use setenv ethaddr to configure the MAC address of the Ethernet controller.
> 
> Is it ok to resend the patch with the above changes ?

I think yes.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Be wiser than other people if you can, but do not tell them so.
                                       -- Philip Earl of Chesterfield