[U-Boot] [patch 1/2] fix USB initialisation procedure

Wolfgang Denk wd at denx.de
Thu Oct 9 20:42:06 CEST 2008


Dear Markus =?iso-8859-1?Q?Klotzb=FCcher?=,

In message <20081009144357.GA27523 at lisa> you wrote:
>
> > > >  	if (dev->status == 0)
> > > >  		return dev->act_len;
> > > please add {} to if too or remove the else
> > > > -	else
> > > > +	else {
> > > > +		/* Let's wait a while for the timeout to elaps.
> > > > +		 * it has no real use, but it keeps the interface happy. */
> > > > +		wait_ms(timeout);
> > > >  		return -1;
> > > > +	}
...
> > Actually the "else" should be removed.
> 
> How so?

Like that:

	if (dev->status == 0)
		return dev->act_len;
	
	/*
	 * Let's wait a while for the timeout to elaps.
	 * it has no real use, but it keeps the interface happy.
	 */
	wait_ms(timeout); 
	return -1;

What exactly was your problem?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Very ugly or very beautiful women should be flattered on their
understanding, and mediocre ones on their beauty.
                                       -- Philip Earl of Chesterfield


More information about the U-Boot mailing list