[U-Boot] [PATCH RFC] mpc8572ds relocatable

[Wolfgang Denk]

Dear Ed Swarthout,

In message <1220862412-16162-1-git-send-email-Ed.Swarthout at freescale.com> you wrote:
> Fixes boot crash from bad string pointers in get_table_entry_name
> when flash is erased or differs from current u-boot image.
> 
> Signed-off-by: Ed Swarthout <Ed.Swarthout at freescale.com>
> ---
> 
> Fix was pointed out by Peter Tyser in Image.c get_table_entry_name thread.
> 
> This redoes Grant Likey's relocation change, but leaves control to each board.
> This also fixes the "mii dump" command when flash is erased.
> Tested with gcc 4.2

NAK.


Sorry, this doesn't work. We cannot have one board compile this way,
and another one another way - one working with that  tool  chain  and
the other with another tool chain only.

Theproblem you're addressing is a bug, and not only  on  this  single
board, but everywhere. So it must be fixed everywhere.

Either we  add  manual  relocation  to  these  pointers  like  we  do
elsewhere (that would be my recommendation for a quick workaround aka
bug  fix for this release), or we should find a clean way to get real
relocation working (that would be much better, but probably it is too
late for this release).

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The optimum committee has no members.
                                                   - Norman Augustine