[U-Boot] [PATCH] cmd_i2c: Update available commands when CONFIG_I2C_CMD_TREE is defined

Ben Warren biggerbadderben at gmail.com
Wed Oct 15 05:41:00 CEST 2008


Peter,

On Tue, Oct 14, 2008 at 1:50 PM, Peter Tyser <ptyser at xes-inc.com> wrote:
> Hello Wolfgang,
>
>> In message <1222883937-2640-1-git-send-email-ptyser at xes-inc.com> you wrote:
>> > If CONFIG_I2C_CMD_TREE is defined, individual i2c commands such as
>> > 'imd', 'imm', 'imw', etc should not be available as their functionality
>> > is duplicated in the 'i2c' command.
>>
>> If I remember correctly, there has been discussion to keep both
>> variants in parallel for some transition time.
>>
>> I have added a link to your patch to the Feature Removal page at
>> http://www.denx.de/wiki/U-Boot/TaskFeatureRemovalSchedule
>> so we will not forget this as soon as e have a formal Feature Removal
>> file in place.
>>
>> Is this OK with you?
>
> According to the top-level README file since at least U-Boot v1.1.5:
> "CONFIG_I2C_CMD_TREE is a recommended option that places
> all I2C commands under a single 'i2c' root command.  The
> older 'imm', 'imd', 'iprobe' etc. commands are considered
> deprecated and may disappear in the future."
>
> I personally think that the 2 year warning the README gave is sufficient
> but don't have a strong preference if this feature is removed now or at
> a later date.  Either way, I think the task feature removal schedule in
> general is a great idea.
>
As the author of this stuff, I apologize for the ambiguous wording.
At the time, I lobbied to have the old-style commands removed and IIRC
we settled on leaving them for a couple of releases.  You have my full
ACK to purge it at any time.

> Best,
> Peter
>
regards,
Ben


More information about the U-Boot mailing list