[U-Boot] [PATCH 1/1] add tool to check patch and file for CFG_ presence

Wolfgang Denk wd at denx.de
Thu Oct 16 22:18:18 CEST 2008


Dear Jean-Christophe PLAGNIOL-VILLARD,

In message <1224184956-2864-1-git-send-email-plagnioj at jcrosoft.com> you wrote:
> 
> +find_config_errors:
> +	@echo "Search for config errors"
> +	@git-grep CFG_ | cut -d: -f1 | sort -u | xargs -I {} tools/find_config_errors -f {}
> +

Hm... should we not just use "grep -r *" so this will also work when
we don't have a full git repository?

And instead of running another process with "cut", a "-l" argument to
grep (or even git-grep) would do the same? [Also note that "git-grep"
is deprecated, "git grep" should be used instead.]

I think we should change this into:

	grep -l -r * | xargs tools/find_config_errors -f

What do you think?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
There are three ways to get something  done:  do  it  yourself,  hire
someone, or forbid your kids to do it.


More information about the U-Boot mailing list