[U-Boot] [PATCH 2/2][for v2008.10] 85xx: Using proper I2C source clock divider for MPC8544

Wolfgang Denk wd at denx.de
Mon Oct 20 21:22:43 CEST 2008


Dear Jerry Van Baren,

In message <48FC815A.90501 at ge.com> you wrote:
>
> > Would it really have been so hard to add this line?
> > 
> > /* The MPC8544 RM says it's bit 26, but it's really bit 28 */
> 
> I have to agree with Timur, we *need* a comment in the source code for 
> future reference.  The git log is good, but not sufficient.

Agreed, but in the first place we should figure out if it's  *really*
bit 28 (then the new code is wrong), or bit 24, then the doc is wrong
again.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
This is an unauthorized cybernetic announcement.


More information about the U-Boot mailing list