[U-Boot] [PATCH 1/2] bootm: Add subcommands

Kumar Gala galak at kernel.crashing.org
Wed Oct 22 01:04:21 CEST 2008


On Oct 21, 2008, at 2:44 PM, Jerry Van Baren wrote:

>
> I've been hacking at cmd_bootm.c and image.c.  The direction I'm  
> hacking in is:
> * Move boot_* stuff from image.c into cmd_bootm.c
>  - Calling out to another file to a function unused in that file?  
> Ugly.
> * Move the FIT stuff out of image.c into a new file fit_image.c
>  - The resulting files are more cohesive and less BIG.
> * Move the im* commands out of cmd_bootm.c into a new file cmd_image.c
>  - At one time, I was of the opinion that "bootm (loados|ramdisk|fdt)"
>      should be "ldimage (os|ramdisk|fdt)".  I'm less sure of myself,
>      but have not totally discarded the opinion.
>  - Looking in cmd_bootm.c for im* commands is rather unintuitive.

these all sound like good things.  I've posted a "clean" patchset for  
Wolfgang to apply to 'master' or 'testing'

- k


More information about the U-Boot mailing list