[U-Boot] [PATCH] [ARM] Move machine specific code to board at s3c64xx

[Guennadi Liakhovetski]

On Thu, 23 Oct 2008, Wolfgang Denk wrote:

> Dear Guennadi Liakhovetski,
> 
> In message <Pine.LNX.4.64.0810230954380.4977 at axis700.grange> you wrote:
> > 
> > > > +       /* Xm0CSn[2] = OneNANDC CS0 or NFCON CS0, Xm0CSn[3] = SROMC CS3 */
> > > 
> > > Right, and also add OneNAND & NFCON is depends on XNANDSEL.
> > 
> > In the datasheet this signal is called XSELNAND. And I don't think we have 
> > to quote this in the comment. This is a hardware configuration issue, not 
> > software, and we are not explaining the complete NAND configuration here, 
> > otherwise we would have to mention OM signals too, maybe more.
> 
> Hey, actually I do think that describing which hardware configurations
> the software performs is a Good Thing (TM).

Exactly, "which hardware configurations the software performs", XSELNAND 
is not performed in software, this is just a pin you wire high or low on 
your board. That's why I said we might not need to comment upon it. That's 
how I interpreted the datasheet anyway.

Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de