[U-Boot] [PATCH 1/2] IOMUX: Add console multiplexing support.

Gary Jennejohn garyj at denx.de
Fri Oct 24 14:25:49 CEST 2008


On Fri, 24 Oct 2008 13:18:42 +0200
Wolfgang Denk <wd at denx.de> wrote:

Dear Wolfgang,

> In message <20080915110101.6b5e0a5b at peedub.jennejohn.org> you wrote:
> > On Sun, 14 Sep 2008 23:59:39 +0200
> > Jean-Christophe PLAGNIOL-VILLARD <plagnioj at jcrosoft.com> wrote:
> >
> > > > +#if defined(CONFIG_IO_MUX)
> > > > +/** Console I/O multiplexing *******************************************/
> > > > +
> > > > +static device_t *tstcdev;
> > > > +device_t *console_devices[MAX_FILES][MAX_CONSARGS];
> > >
> > > please use a list_head instead
> > >
> >
> > This is an excellent suggestion.  Thanks!
>
> I understood that you would repost a new, modified patch which uses
> this suggestion, but I haven't seen any repost sice.
>
> You know that the merge window is open right now - do you plan to
> repost this stuff any time soon?
>

I actually solved the problem by using realloc() rather than using a
list_head.

I've merged the console multiplexing stuff into HEAD but hesitate to
post it because my previous patch (setting GD_FLG_DEVINIT) is still
unresolved.

But if the window is now open I'll post the new patch without resolution
of the other one.  However, this approach may well lead to an unusable
U-Boot if the user wants to set nc as a console in the environment.

---
Gary Jennejohn
*********************************************************************
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
*********************************************************************


More information about the U-Boot mailing list