[U-Boot] [PATCH 2/2] i.MX31: switch to CFG_HZ=1000

Wolfgang Denk wd at denx.de
Tue Sep 16 12:39:30 CEST 2008


Dear Jean-Christophe PLAGNIOL-VILLARD,

In message <1221553118-15819-3-git-send-email-plagnioj at jcrosoft.com> you wrote:
> From: Guennadi Liakhovetski <lg at denx.de>
> 
> Switch to the standard CFG_HZ=1000 value, while at it, minor white-space
> cleanup, remove CFG_CLKS_IN_HZ from config-headers. Tested on mx31ads,
> provides 2% or 0.4% precision depending on the
> CONFIG_MX31_TIMER_HIGH_PRECISION flag. Measured with stop-watch on 100s
> boot-delay.
> 
> Signed-off-by: Guennadi Liakhovetski <lg at denx.de>

Why are you reposting this?

And, even worse, why  are  you  reposting  a  patch  which  you  here
attribute  to  Guennady (without adding your own Signed-off-by line),
but this is actually not the original patch as submitted by  Guennadi
but a modified version where you meddled with whitespaces (corrupting
Guennadi's  nice  alignment  of  the  comments)?  I see that you also
cleaned up some coding style violations (like trailing white  space),
but not all of them (like '^ \t' pattern). And you added comments.

You must not modify other people's patches without recording the fact
that you did so. If you change their code, you have  to  record  this
fact at least by adding your own Signed-off-by: line to the patch.


Please clean this up before resending a pull request.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
All men should freely use those seven words which have the  power  to
make any marriage run smoothly: You know dear, you may be right.


More information about the U-Boot mailing list