[U-Boot] [PATCH 3/3] 85xx/86xx: Ensure MP boot page is not used

[Wolfgang Denk]

Dear Kumar Gala,

In message <1238601989-6251-3-git-send-email-galak at kernel.crashing.org> you wrote:
> We had a bug on 86xx in which the boot page used to bring up secondary
> cores was being overwritten and used for the malloc region in u-boot.
> 
> We need to reserve the region of memory that the boot page is going to
> be put at so nothing uses it.
> 
> Signed-off-by: Kumar Gala <galak at kernel.crashing.org>
> Acked-by: Becky Bruce <beckyb at kernel.crashing.org>
> ---
> * No real change, just here for completeness
...
> +#ifdef CONFIG_MP
> +extern u32 determine_mp_bootpg(void);
> +#endif

Please provide a prototype in some appropriate header file so we can
get rid of this "extern".

>  #ifdef CONFIG_SYS_UPDATE_FLASH_SIZE
>  extern int update_flash_size (int flash_size);
>  #endif
> @@ -444,6 +448,15 @@ void board_init_f (ulong bootflag)
>  
>  	addr = CONFIG_SYS_SDRAM_BASE + get_effective_memsize();
>  
> +#if defined(CONFIG_MP) && (defined(CONFIG_MPC86xx) || defined(CONFIG_E500))
> +	/* We need to make sure the location we intend to put secondary core
> +	 * boot code is reserved and not used by any part of u-boot */

Incorrect multiline comment.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
If all you have is a hammer, everything looks like a nail.