[U-Boot] Compilation warning: "MSR_RI" redefined

Detlev Zundel dzu at denx.de
Thu Apr 2 10:55:00 CEST 2009


Hi Stefan,

> your patch 7b5611cdd12ca0cc33f994f0d4a4454788fc3124 [inka4x0: Add hardware 
> diagnosis functions for inka4x0] introduced all kind of new defines in the 
> ns16550.h header resulting in a warning on some 4xx platforms:
>
> [stefan at kubuntu u-boot (master)]$ ./MAKEALL ml300
> Configuring for ml300 board...
> In file included from serial.c:53:
> /home/stefan/git/u-boot/u-boot/include/ns16550.h:151:1: warning: "MSR_RI" 
> redefined
> In file included from serial.c:41:
> /home/stefan/git/u-boot/u-boot/include/asm/processor.h:48:1: warning: this is 
> the location of the previous definition
>
> I suggest to either remove this MSI_RI from the header again (it doesn't seem 
> to be used here) or rename it.

Ok, so much for the plan to add the defines not bit by bit as needed,
but register-wise, while we're there.

I actually would prefer to use UART_MSR_RI, as this is a UART thingy
rather than to remove the define as we surely use the register, so I
feel it worthwhile to have the whole definition on board.

Let me cook up a rename for the UART stuff..

Cheers
  Detlev

-- 
We have a live-manual.  It's called emacs-devel at gnu.org.
You can stick to just reading it, but you can skip to a specific chapter
by simply sending an email asking for it ;-)
                                    -- Stefan Monnier
--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de


More information about the U-Boot mailing list