[U-Boot] [PATCH 2/3] lib_generic: gunzip: New function zunzip

Wolfgang Denk wd at denx.de
Mon Apr 27 14:34:27 CEST 2009


Dear Ricardo Ribalda Delgado,

In message <1240831297-15862-2-git-send-email-ricardo.ribalda at uam.es> you wrote:
> Separate gunzip in
> 
> gunzip: Find the end of the header and call zunzip.
> zunzip: Inflate gunzip block without header.
> 
> UBI fs blocks can be compresed in lzo, zlib or no-compression. The
> current implementation of u-boot supported all the compressions but
> there was a bug in the implementation of the zlib blocks.
> 
> UBIFS's Zlib blocks do not have header but they were compressed using
> gunzip, a function used to decompress gunzip files/sectors with a
> header.
> 
> This patch adds a new function zunzip that uncompress a zlib block with
> no header.
> 
> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda at uam.es>
...

> -	if (r != Z_STREAM_END) {
> +	if ((r != Z_STREAM_END) && (stoponerr==1)) {

I already asked about this change, which ios unrelated to this patch.

Please explain why this is needed, and why you think this should not
be split off into a separate commit?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"More software projects have gone awry for lack of calendar time than
for all other causes combined."
                         - Fred Brooks, Jr., _The Mythical Man Month_


More information about the U-Boot mailing list