[U-Boot] U-Boot and CONFIG_SYS_DAVINCI_BROKEN_ECC

[Scott Wood]

On Mon, Apr 27, 2009 at 12:51:29AM +0200, Wolfgang Denk wrote:
> Dear Jean-Christophe PLAGNIOL-VILLARD,
> 
> In message <20090426224036.GL32215 at game.jcrosoft.org> you wrote:
> > On 11:11 Sun 26 Apr     , David Brownell wrote:
> > > I was looking at the DaVinci NAND support in current U-Boot
> > > code (i.e. 2009.03 plus patches merged since that release),
> > > and am puzzled by the above-named config option.
> > > 
> > > Before I submit a patch to remove it from U-Boot GIT (nothing
> > > there enables it, and it will nastify 4-bit support), I thought
> > > I'd see if anyone knows exactly what software it was trying to
> > > emulate.  Differences from the current NAND driver in GIT:

It is for compatibility with a widely-deployed legacy ECC layout -- more
details can be found in the list archives.

> Hm... I don't think this is needed.
> 
> Since there are no users of this code in U-Boot, we can as well
> remove it without warning.

You're assuming that it's not being used by users manually enabling it in
their config.h.  It should have been a CONFIG_ rather than CONFIG_SYS_.

-Scott