[U-Boot] [PATCH 4/9] A driver for the S6E63D6 SPI display controller from Samsung

Guennadi Liakhovetski lg at denx.de
Thu Feb 5 11:19:38 CET 2009


On Wed, 4 Feb 2009, Anatolij Gustschin wrote:

> Hi Guennadi,
> 
> > +struct s6e63d6 {
> > +	unsigned int bus;
> > +	unsigned int cs;
> > +	struct spi_slave *slave;
> > +};
> 
> could we use "bus" and "cs" from struct spi_slave? "struct spi_slave"
> declares them already. Maybe we should drop struct s6e63d6 entirely and use
> struct spi_slave instead?

No, cs and bus here are input parameters, set up by the caller to 
s6e63d6_init() and used by the latter to setup the SPI-slave. slave is 
driver-"private" field, the caller doesn't need to know what is under 
s6e63d6.

Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de


More information about the U-Boot mailing list