[U-Boot] [PATCH] ppc4xx: Make PCIE support selectable

Wolfgang Denk wd at denx.de
Sat Feb 7 22:39:48 CET 2009


Dear Dirk Eibach,

In message <1233670521-24501-1-git-send-email-eibach at gdsys.de> you wrote:
> On some platforms PCIE support is not required, but would be included
> because the cpu supports it. To reduce fooprint it is now configurable
> via CONFIG_PCI_DISABLE_PCIE.
> 
> Signed-off-by: Dirk Eibach <eibach at gdsys.de>
> ---
>  cpu/ppc4xx/4xx_pci.c  |    5 +++--
>  cpu/ppc4xx/4xx_pcie.c |    2 +-
>  2 files changed, 4 insertions(+), 3 deletions(-)

Sorry, I'm too late with my review comment:

Please document the new CONFIG_PCI_DISABLE_PCIE in the README.


As Stefan has already pushed this into mainline, please send it as
additional patch.

Thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Be careful what you wish for. You never know who will be listening.
                                      - Terry Pratchett, _Soul Music_


More information about the U-Boot mailing list