[U-Boot] [PATCH 2/3][v3] dnet: driver for Dave DNET ethernet controller

Wolfgang Denk wd at denx.de
Mon Feb 9 15:27:53 CET 2009


Dear Ilya,

In message <49902403.2010406 at emcraft.com> you wrote:
> 
...
> >> +    u32 TX_JUMBO_CNT;
> >> +    u32 TX_BYTE_CNT;
> >> +} __attribute__((packed));
> >>   
> > Why is this packed?  All fields are 32-bit aligned already.
> 
> Generally, I prefer declaring such structures with ((packed)) regardless
> of if it's really do something. Just to show that it should be packed.

Can you please verify that it works as well without the "packed", and
if it does (as expected) resubmit without it?

Thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Drawing on my fine command of language, I said nothing.


More information about the U-Boot mailing list