[U-Boot] [PATCH 1/2] net: Sort Makefile labels

[Wolfgang Denk]

Dear monstr at monstr.eu,

In message <d4fd46d3b2d27747b728da37fad3ebca3732d837.1231154122.git.monstr at monstr.eu> you wrote:
> From: Michal Simek <monstr at monstr.eu>
> 
> 
> Signed-off-by: Michal Simek <monstr at monstr.eu>
> ---
>  drivers/net/Makefile |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/Makefile b/drivers/net/Makefile
> index 631336a..128dc11 100644
> --- a/drivers/net/Makefile
> +++ b/drivers/net/Makefile
> @@ -26,6 +26,7 @@ include $(TOPDIR)/config.mk
>  LIB	:= $(obj)libnet.a
>  
>  COBJS-$(CONFIG_DRIVER_3C589) += 3c589.o
> +COBJS-$(CONFIG_PPC4xx_EMAC) += 4xx_enet.o
>  COBJS-$(CONFIG_DRIVER_AX88180) += ax88180.o

What makes you think that CONFIG_PPC4xx_EMAC has a good place between
CONFIG_DRIVER_3C589 and CONFIG_DRIVER_AX88180?

>  COBJS-$(CONFIG_BFIN_MAC) += bfin_mac.o
> @@ -54,11 +55,11 @@ COBJS-$(CONFIG_NS8382X) += ns8382x.o
>  COBJS-$(CONFIG_DRIVER_NS9750_ETHERNET) += ns9750_eth.o
>  COBJS-$(CONFIG_PCNET) += pcnet.o
>  COBJS-$(CONFIG_PLB2800_ETHER) += plb2800_eth.o
> -COBJS-$(CONFIG_PPC4xx_EMAC) += 4xx_enet.o

that was ok here.

>  COBJS-$(CONFIG_DRIVER_RTL8019) += rtl8019.o

...while this isn't.

>  COBJS-$(CONFIG_RTL8139) += rtl8139.o
>  COBJS-$(CONFIG_RTL8169) += rtl8169.o
>  COBJS-$(CONFIG_DRIVER_S3C4510_ETH) += s3c4510b_eth.o
> +COBJS-$(CONFIG_SH_ETHER) += sh_eth.o
>  COBJS-$(CONFIG_DRIVER_SMC91111) += smc91111.o
>  COBJS-$(CONFIG_DRIVER_SMC911X) += smc911x.o
>  COBJS-$(CONFIG_TIGON3) += tigon3.o bcm570x_autoneg.o 5701rls.o
> @@ -68,7 +69,6 @@ COBJS-$(CONFIG_ULI526X) += uli526x.o
>  COBJS-$(CONFIG_VSC7385_ENET) += vsc7385.o
>  COBJS-$(CONFIG_XILINX_EMAC) += xilinx_emac.o
>  COBJS-$(CONFIG_XILINX_EMACLITE) += xilinx_emaclite.o
> -COBJS-$(CONFIG_SH_ETHER) += sh_eth.o

Actually we should perform a global s/CONFIG_DRIVER_/CONFIG_/, me
thinks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Worlds may change, galaxies disintegrate, but a woman always  remains
a woman.
	-- Kirk, "The Conscience of the King", stardate 2818.9